hack: resolve the kube context before installing micro-VM deps - #1027
Open
Benjamin Elder (BenTheElder) wants to merge 1 commit into
Open
hack: resolve the kube context before installing micro-VM deps#1027Benjamin Elder (BenTheElder) wants to merge 1 commit into
Benjamin Elder (BenTheElder) wants to merge 1 commit into
Conversation
Bowei Du (bowei)
approved these changes
Aug 17, 2026
kubectl silently falls back to localhost:8080 when neither --context nor
a kubeconfig current-context is set, so install-microvm-deps.sh died on
the SandboxConfig apply with a bare "connection refused" -- after it had
already assembled the assets and uploaded them to the bucket, which is
the slow part.
Check that a target cluster resolves before doing any of that work, and
print which knob to set. Also thread KUBECTL_CONTEXT into the
install-microvm-deps.sh call in run-microvm-demo.sh, mirroring the
install-ate.sh calls just above it, and give install-ate-kind.sh the
same kind-${KIND_CLUSTER_NAME} default that run-microvm-demo-kind.sh
already has -- it set every other kind-specific variable but left the
context to whatever the kubeconfig happened to point at. An explicit
KUBECTL_CONTEXT still wins everywhere.
Benjamin Elder (BenTheElder)
force-pushed
the
hack-pin-kubectl-context
branch
from
August 18, 2026 01:34
19b48a4 to
1c52042
Compare
Collaborator
Author
|
[trivial rebase on main to pickup CI fixes] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc Bowei Du (@bowei) yeah ... we need to get these rewritten