ateom: drop the family from the atunnel ingress listen defaults - #1080
Open
Yuan Gao (ygao-g) wants to merge 3 commits into
Open
ateom: drop the family from the atunnel ingress listen defaults#1080Yuan Gao (ygao-g) wants to merge 3 commits into
Yuan Gao (ygao-g) wants to merge 3 commits into
Conversation
Both ateom herders defaulted the actor ingress flags to "0.0.0.0:443" and "0.0.0.0:444", which reads as IPv4-only. It never was: Go treats an unspecified address as a wildcard and binds it dual-stack, so the sockets already served both families. Spell the defaults ":443" and ":444" so the flag says what it does, and note why in a comment. Part of the dual-stack actor networking series; no behavior change.
Yuan Gao (ygao-g)
force-pushed
the
ateom-atunnel-listen-defaults
branch
from
August 20, 2026 05:19
368d702 to
53e5195
Compare
The worker Deployment passes --atunnel-listen-address=0.0.0.0:443 and --atunnel-connect-listen-address=0.0.0.0:444 explicitly, so the ateom flag defaults never reach a deployed worker and the command line a reader inspects still says IPv4. Spell these ":443" and ":444" to match. Part of the dual-stack actor networking series; no behavior change, as Go binds an unspecified IPv4 wildcard dual-stack either way.
The comment singled out the ingress addresses as unspecified wildcards and said egress stays IPv4 below. 0.0.0.0 is unspecified too, so Go binds the egress listener dual-stack as well and the distinction does not exist -- which reintroduces exactly the misreading the rest of this change removes. Egress keeps the v4 spelling as a marker until the actor datapath carries v6; that is a note to a future reader, not a property of the socket.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #246.
Both ateom herders default the actor ingress flags to
0.0.0.0:443and0.0.0.0:444, and theworker Deployment passes those same two values explicitly — so the command line on a running worker
reads IPv4-only. It never was: Go treats an unspecified IPv4 address as a wildcard on a listen and
binds it dual-stack, so those sockets already served both families. This spells all four
:443and:444so the flag says what it does.No behavior change. The egress listen address stays
0.0.0.0:15001until the actor datapathcarries v6. #1042 carried the same lines under its egress pin and is closed as superseded.
🤖 Generated with Claude Code