Repository navigation
ci: grant actions:write for the DEC-074 artifact prune - #18
Merged
Merged
Conversation
The devkit's reusable plugin-e2e now enforces count-based artifact retention (keep the last 5 runs) by DELETING superseded artifacts via the Actions API. A reusable workflow's job permissions are CAPPED by the caller's grant, so without actions:write here the prune degrades to a warning and artifacts accumulate unbounded. Only the permission line is added. This repo's caller predates the capture_all_traces dispatch input that the current template carries; bringing it up to date is a separate change and is deliberately NOT bundled here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-line permission grant so the devkit's new count-based artifact retention (keep the last 5 runs) actually works in this repo.
This repo calls the reusable
plugin-e2e.yml@main, so it picked up the prune step the moment testkit#49 merged. A reusable workflow's job permissions are capped by the caller's grant — withoutactions: writehere the prune logs a warning and deletes nothing, so e2e artifacts keep accumulating.Non-fatal either way (the prune step is
continue-on-error), but until this lands the feature is inert here.devkit-synccannot deliver this: it deliberately never writes.github/workflows/. Equivalent to re-runningmake link-workflows.Note: unlike the other three consumers, this repo's caller is an older revision of the template — it lacks the
capture_all_tracesdispatch input. I deliberately added only the permission line rather than silently bringing the whole file up to date; that's a separate change and should be its own PR.