Support MCP elicitation if the client does#268
Conversation
|
@benbrandt Hi! Could you share why Is something needed from ACP before it can be supported properly? Thanks! |
* build(deps): bump openai/codex-action in the github-actions group (agentclientprotocol#273) Bumps the github-actions group with 1 update: [openai/codex-action](https://github.com/openai/codex-action). Updates `openai/codex-action` from 1.9 to 1.11 - [Changelog](https://github.com/openai/codex-action/blob/main/CHANGELOG.md) - [Commits](openai/codex-action@10cb888...52fe01e) --- updated-dependencies: - dependency-name: openai/codex-action dependency-version: '1.11' dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-actions ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Support MCP elicitation if the client does (agentclientprotocol#268) * Support ACP form elicitation capability * Auto-resolve stale user input elicitations * Support Other answers in user input elicitations * Complete accepted URL elicitations on resolution * Disable app-server elicitation opt-in * Remove request_user_input handling * Update to ACP SDK 1.2.1 (agentclientprotocol#275) Also uses the elicitation helpers * Release v1.1.1 * Update codex to 0.144.0 * Release v1.1.2 * test: Fix missing model id * Update codex to 0.144.1 (agentclientprotocol#282) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * feat: implement configurable LLM providers (agentclientprotocol#272) * feat: implement configurable LLM providers (providers/list, set, disable) Implement the Configurable LLM Providers RFD * cleanup: remove dead code & simplify types --------- Co-authored-by: Alexandr Suhinin <alexandr.suhinin@jetbrains.com> * Capitalize reasoning effort labels (agentclientprotocol#277) * Add ACP plan mode user input bridge * Publish package under melonite scope (#3) * Forward native request_user_input and proposed plans * Expose Codex form field mappings to ACP clients * Allow scoped releases without a live API secret * Revert "Allow scoped releases without a live API secret" This reverts commit 1e738ba. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Ilia.Shulgin <ilia.shulgin@jetbrains.com> Co-authored-by: acp-release-bot[bot] <246668977+acp-release-bot[bot]@users.noreply.github.com> Co-authored-by: Mark Tkachenko <onemangd@gmail.com> Co-authored-by: Alexandr Suhinin <alexandr.suhinin@jetbrains.com> Co-authored-by: Josh Kent <81527181+joshkent94@users.noreply.github.com>
|
My understanding is this is only triggered if you enable the global experimental flag, which would have effected more parts of the adapter than I would have liked. |
|
Thanks for answering! As I understand it, the request_user_input tool is available in plan mode without experimental flags. However, it can be enabled in all modes via the default_mode_request_user_input feature flag, which I often use. I don't understand how this flag could affect other parts of the adapter besides elicitation, but I may be wrong. |
|
Added back support got handle it if it gets called by codex: #291 |
|
@benbrandt I tried it in my client and it looks great! One minor question: why actual question is sent as |
|
I added #299 with changing structure of elicitation for |
2 participants
Holding off on the ask user question tool until it is less experimental.