Fix readonly - #487
Open
quazgar wants to merge 2 commits into
Open
Conversation
Renames the existing ReadOnly mode to EditInternal to better reflect its actual permissions and clarify the mode's behavior in the UI. Changes: - Rename AgentMode.ReadOnly to AgentMode.EditInternal - Change mode ID from "read-only" to "edit-internal" - Update display name to "Ask for approval" - Update description to "Edit workspace files, ask for approval to edit external files or use the internet" - Update AgentMode.all() to use EditInternal This is a refactoring of the existing mode with no functional changes - it still uses the same workspace-write sandbox policy and permissions. The name and description are now clearer about what the mode actually does. Addresses part of agentclientprotocol#450
Adds a new read-only mode that provides true read-only access, preventing any file modifications without explicit user approval. Changes: - Add AgentMode.ReadOnly: read-only sandbox (type: "readOnly", networkAccess: false) - Change name to "Read-only" - Change description to "Inspect only, ask for approval to modify any files" - Update AgentMode.all() to include ReadOnly first This provides users with a true inspection mode as requested in agentclientprotocol#450. The three approval-based modes are now: 1. Read-only: inspect only, ask for approval on any modification 2. Ask for approval: edit workspace files, ask for approval on external changes 3. Approve for me: auto-approve safe operations 4. Full access: no restrictions Fixes agentclientprotocol#450
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempting a fix for #450, reintroducing read-only mode.
Written by Copilot, human-reviewed.