fix: return AuthRequired for expired ChatGPT credentials - #498
Open
ruixingshi wants to merge 1 commit into
Open
Conversation
Return the standard ACP authentication error for terminal ChatGPT auth failures even when the session still has a saved account. Preserve existing handling for configured API keys, custom providers, retryable errors, and negotiated typed failures. Add regression coverage and document the standard-client behavior. Validated with 62 related tests, typecheck, and build. Live expired-login recovery has not been tested end to end.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return the standard ACP authentication error for terminal ChatGPT auth failures even when the session still has a saved account. Preserve existing handling for configured API keys, custom providers, retryable errors, and negotiated typed failures.
Add regression coverage and document the standard-client behavior. Validated with 62 related tests, typecheck, and build. Live expired-login recovery has not been tested end to end.
Related issue:#495