fix: emit completed messages when providers omit deltas - #500
Open
quabug wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some OpenAI-compatible Responses providers, including Volcengine Ark, deliver final text without
item/agentMessage/delta. Codex app-server still emitsitem/startedanditem/completedfor anagentMessagecarrying the full text, but codex-acp currently ignores both. ACP clients receive reasoning and a successfulend_turnwith no final message.Track agent-message item IDs that emitted deltas. On
item/completed, retain the current no-op for those streamed messages; otherwise emit the completed item's non-empty text once, including its phase metadata.Validation:
npm run typechecknpx vitest run --no-file-parallelism src/__tests__/CodexACPAgent/agent-message-events.test.tsnpm run builddeepseek-v4-flashACP turn: before this change, only the thought event arrived; after this change, the client received exactly one finalagent_message_chunkcontainingARK_ACP_RAW_OK.