Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codexandjetbrains.airvalues in their owned writers, using the serialized session metadata owner from fix: resynchronize current session metadata on ACP v2 resume #717. A status/goal/failure/report/archive update no longer drops sibling fields merely because v2 replaces the whole top-level namespace value.Checked against ACP
a965f1f1,docs/protocol/v2/extensibility.mdx:103-150: each top-level metadata value is replaced whole, and nested nulls are ordinary data. Producers that share a namespace therefore need to construct its current complete value, rather than relying on clients to deep-merge their partial objects.Scope and cost
This preserves the current namespace layout and extension contract. Complete namespace updates may repeat unchanged values, including file-change reports and failure revisions. Splitting metadata keys or moving request-scoped report data to a different notification location would be a separate compatibility decision. Native setup seeding and newer upstream schema additions are not redesigned here. No review/checklist Markdown file is added.
Validation
npm run typechecknpm run buildnpm test: 2,365 passed, 39 skippednpm run test:integration: all 19 passednpm run codex-test -- -p "Reply with exactly OK. Do not use tools or modify any files." -o summary: completed withend_turngit diff --checkNew wire tests exercise the actual goal, local-command file-report, typed-failure, goal-clear, and archive sequence on both protocol versions, including post-archive suppression. They also cover independent Codex fields, concurrent AIR writers, unrelated JetBrains/root fields, nested nulls, and routed child isolation. A metadata-owner test covers accompanying title/activity fields. All existing snapshots, including v1 snapshots, remain unchanged.