Repository navigation
fix(examples): finalize open tool calls when the v1 example's turn is cancelled - #327
Merged
Merged
Conversation
… cancelled The v1 example agent left a tool call pending when the turn was cancelled mid-way. Track open tool calls per turn and send a final `failed` update (v1 has no `cancelled` tool call status) for each before the prompt response returns. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v1 example agent (
src/examples/agent.ts) could leave a tool callpending(e.g.call_1) if the turn was cancelled between steps.Now
prompttracks the tool calls opened during the turn and, when the turn ends early (cancelled or errored), sends a finaltool_call_updatewith statusfailedfor each unfinished one before responding. v1 has nocancelledtool call status, sofailedis the right final status.Tested by driving the agent over stdio and sending
session/cancelright aftercall_1appears: before this change the turn returnedcancelledwithcall_1stillpending; nowcall_1getsfailedfirst. Cancelling during the permission request still failscall_2once.npm run checkpasses.🤖 Generated with Claude Code