feat(sdk): add step_type as input parameter to the control decorator and evaluate_controls function - #262
Merged
namrataghadi-galileo merged 4 commits intoSep 18, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
josjeon
reviewed
Sep 17, 2026
Collaborator
There was a problem hiding this comment.
Question:
So my understanding is that an unknown type/typo like step_type="sesion" passes through and matches no controls, and process() early returns is_safe=True, confidence=1.0 like:
agent-control/engine/src/agent_control_engine/core.py
Lines 642 to 649 in bd90753
so it reads the same as a genuine pass. Assuming that's intentional for now?
Contributor
Author
|
@josjeon Yes—that is intentional with the current generic string-based design.
|
wrisa
reviewed
Sep 17, 2026
josjeon
self-requested a review
September 18, 2026 14:44
josjeon
approved these changes
Sep 18, 2026
wrisa
approved these changes
Sep 18, 2026
namrataghadi-galileo
enabled auto-merge (squash)
September 18, 2026 15:51
namrataghadi-galileo
deleted the
feature/SAO-17170-support-step-type-in-control-decorator
branch
September 18, 2026 15:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Existing llm/tool inference remains unchanged.
This is to accomodate controls at different levels especially Luna but not restricted to Galileo levels only.
Scope
User-facing/API changes:- Added step_type: str | None to @agent_control.control().
Internal changes:- Preserved custom decorator arguments and telemetry classifications.
Out of scope:- Google ADK and Strands adapters remain intentionally limited to LLM/tool lifecycle events.
Risk and Rollout
Risk level: low
Rollback plan: Revert this commit.
Testing
make check(or explained why not)Checklist