Conversation
Treat initial and repeated initAgent calls as one registration upsert contract. Explicit agent management routes remain on AGENTS_UPDATE. Refs #263
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
initAgentcreate-or-refresh flow on the existingAGENTS_CREATEregistration authorization.AGENTS_UPDATEcheck that made an authenticated,non-admin SDK caller fail when it restarted with the same agent name.
force-replace, and the built-in non-admin header-auth flow.
Closes #263.
Related downstream authorization work: rungalileo/orbit#2281.
Scope
refresh an existing same-name registration within their namespace, including
the SDK-default overwrite flow and force-replace recovery.
initAgentno longer performs a second authorization withAGENTS_UPDATE; its existingAGENTS_CREATEprincipal and target namespacechecks remain in place.
PATCH /agents/{name}. Those explicit management routes still requireAGENTS_UPDATEand remain admin-only under the built-in header provider.Risk and Rollout
same-name registration within its namespace, including force-replacing
corrupted registration data. This matches the endpoint's documented
initialize-or-update contract; per-agent ownership remains a separate concern.
AGENTS_UPDATEauthorization checks.
Testing
make check(localmakeis unavailable because the configured Xcodedeveloper toolchain fails to load). Ran the relevant commands directly:
completed with the downstream Orbit branch)
Checklist
initAgentalready documents initialize-or-update and idempotent behavior)and denied explicit control mutations in the combined DevStack