Repository navigation
feat(compositions): id selectors, insert and update commands, live suggestions - #296
Draft
ben-kalmus wants to merge 4 commits into
Draft
ben-kalmus wants to merge 4 commits into
ben-kalmus wants to merge 4 commits into
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… commands Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 105 |
| Duplication | 43 |
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
upsertis replaced byinsert <id>andupdate [id].--interactivesuggests live values with Tab (indices, attributes, sort labels, filters). Shell completion covers composition and rule ids.Prerequisite
TEMP replace the SDKcommit, to drop once feat(go): expose field description and example metadata in generated models api-clients-automation#7180 is released.Stacked PRs
insert/update, live suggestionsChanges
insert/update(compositions and rules):insertcreates under a typed id.updateedits an existing one and shows a selector when the id is omitted.upserttook either a new or an existing id, so it could not offer a selector. A selector only fits editing, and creating needs a typed new id. Both still send the same PUT.get,delete,sorting-strategyandrules get|delete|listalso select the id when omitted on a terminal. Without a terminal, a missing id is still an error.filterstemplates (attribute:) andsortBylabels. An API error just means no suggestions.cmdutil.CompositionIDsandCompositionAndRuleIDscomplete ids for the valid args.pkg/cmd/compositions/internal(select.go,suggest.go).Notes
CookTime:, type the rest instead.compositions searchhas no index prompt, sofiltersoffers only the SDK example there.Testing
go test ./pkg/...passes and each commit builds.🤖 Generated with Claude Code