You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
LogTracer.set()'s parameter has a type of string but the print functions use any. All functions seem to have the same general purpose: to log the argument given Well, which type is it then? Is set() really meant to have a different type than the rest?
I designed that way so that LogTracer.set() directly sets the string value that will be displayed whereas the print functions convert the value to string and then append it to the displayed value. However, I agree that LogTracer.set() should also convert any value to string first before setting it in order to not confuse users. You can make LogTracer.set() in tracers.py have any parameter. I'll fix it in tracers.js and algorithm-visualizer.
Activity
64json commentedon Jul 28, 2019
I designed that way so that
LogTracer.set()directly sets thestringvalue that will be displayed whereas the print functions convert the value tostringand then append it to the displayed value. However, I agree thatLogTracer.set()should also convertanyvalue tostringfirst before setting it in order to not confuse users. You can makeLogTracer.set()intracers.pyhaveanyparameter. I'll fix it intracers.jsandalgorithm-visualizer.