Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and change
Successful cascade stages can return numeric scores alongside boolean flags. The threshold fallback counts those flags as numbers, and merging stages converts them to floats. For example,
{"score": 0.1, "valid": True}passes a 0.5 threshold and can acquire inflated fallback fitness after a merge. A false flag can also block an otherwise passing score.I exclude boolean flags from fallback cascade thresholds and preserve their type when merging stages 1/2/3, so the existing fitness helper continues to ignore them. Numeric scores still normalize to floats. Numeric
combined_scoreprecedence, inclusive thresholds, error filtering, and timeout policy are unchanged. This is a separate successful-cascade path from the timeout work in #446.Validation
OPENAI_API_KEY=test-key-for-unit-tests python -m unittest discover tests: 997 tests, OK.git diff --checkpassed.No paid model calls were made. This does not add general validation of invalid
combined_scorevalues or change the policy for failed later stages.AI assistance: I used OpenAI Codex for implementation, tests, and automated review.