Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When callers reuse or mutate a metrics, prompt, artifacts or metadata dictionary after
log_trace(), buffered traces currently pick up those later changes. The improvement delta and statistics were already calculated, so an exported transition can contain inconsistent metrics and deltas; immediate JSONL writes also behave differently from buffered JSONL and JSON output.I snapshot the retained mutable payloads at log time, including nested artifacts and metadata. Code/response fields and prompt inclusion settings keep their existing behavior. Three regression methods exercise real JSON/JSONL files, reused programs across two transitions, nested payload reuse, and excluded prompts. The original source produces four failing subcases, while immediate JSONL and prompt-exclusion controls pass.
Validation (Python 3.12, no live model calls):
HDF5 payload-type handling and export-level metadata reuse are outside this change; this is separate from #574 and #575.
I used Codex assistance for implementation and regression testing.