Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions scripts/tool-surface-capture.ts
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,8 @@ const comboFromFlippedAxes = (flippedAxes: readonly SurfaceAxis[]): SurfaceCombo
* - disabled-tools: vault_patch_note is cross-referenced from other tools'
* descriptions, so its combo verifies those references disappear when the
* tool is disabled.
* - obsidian-sync: OBSIDIAN_SYNC changes only vault_delete_note's Errors
* list, so one combo pins it; crossing it with the axes would double the
* - obsidian-sync: OBSIDIAN_SYNC changes only vault_delete_note's text,
* so one combo pins it; crossing it with the axes would double the
* baseline without adding a rendered state. */
export const SURFACE_COMBOS: readonly SurfaceCombo[] = [
...axisSubsets.map(comboFromFlippedAxes),
Expand Down
78 changes: 78 additions & 0 deletions src/__tests__/integration/server-error-contracts.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,30 @@ describe("absolute path blocked", () => {
`absolute path blocked: "${serverVaultPath}/moved.md" must be vault-relative`,
)
})

it("vault_list_notes rejects an absolute container path as folder", async () => {
const result = await callTool({
client,
name: "vault_list_notes",
args: { folder: `${serverVaultPath}/Projects` },
})
expectToolError(
result,
`absolute path blocked: "${serverVaultPath}/Projects" must be vault-relative`,
)
})

it("vault_list_files rejects an absolute container path as folder", async () => {
const result = await callTool({
client,
name: "vault_list_files",
args: { folder: `${serverVaultPath}/Projects` },
})
expectToolError(
result,
`absolute path blocked: "${serverVaultPath}/Projects" must be vault-relative`,
)
})
})

// ── Path traversal ───────────────────────────────────────────
Expand Down Expand Up @@ -370,6 +394,42 @@ describe("path traversal blocked", () => {
})
expectToolError(result, "path traversal blocked")
})

it("vault_list_notes rejects a folder escaping the vault root", async () => {
const result = await callTool({
client,
name: "vault_list_notes",
args: { folder: "../outside" },
})
expectToolError(result, 'path traversal blocked: "../outside" escapes vault root')
})

it("vault_list_notes rejects a folder naming the vault root", async () => {
const result = await callTool({
client,
name: "vault_list_notes",
args: { folder: "." },
})
expectToolError(result, 'path traversal blocked: "." resolves to the vault root')
})

it("vault_list_files rejects a folder escaping the vault root", async () => {
const result = await callTool({
client,
name: "vault_list_files",
args: { folder: "../outside" },
})
expectToolError(result, 'path traversal blocked: "../outside" escapes vault root')
})

it("vault_list_files rejects a folder naming the vault root", async () => {
const result = await callTool({
client,
name: "vault_list_files",
args: { folder: "." },
})
expectToolError(result, 'path traversal blocked: "." resolves to the vault root')
})
})

// ── Hidden paths ─────────────────────────────────────────────
Expand Down Expand Up @@ -486,6 +546,24 @@ describe("hidden path blocked", () => {
})
expectToolError(result, "hidden path blocked")
})

it("vault_list_notes rejects a hidden folder", async () => {
const result = await callTool({
client,
name: "vault_list_notes",
args: { folder: ".obsidian" },
})
expectToolError(result, 'hidden path blocked: ".obsidian" targets a hidden file or folder')
})

it("vault_list_files rejects a hidden folder", async () => {
const result = await callTool({
client,
name: "vault_list_files",
args: { folder: ".obsidian" },
})
expectToolError(result, 'hidden path blocked: ".obsidian" targets a hidden file or folder')
})
})

// ── Note not found ───────────────────────────────────────────
Expand Down

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Loading
Loading