Conversation
baev
added
the
pr:improvement
Member
|
@USSQA thanks! can you please add a test for the change? |
|
|
…r plugin - add test with a custom Photographer registered via SPI, asserting its bytes end up in the Allure attachment - add test that a driver without TakesScreenshot support does not break step reporting - add TestPhotographer fixture and META-INF/services registration
Author
|
@baev done ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Fixes #1439
AllureSelenide.getScreenshotBytes()currently bypasses Selenide and calls((TakesScreenshot) WebDriverRunner.getWebDriver()).getScreenshotAs(OutputType.BYTES)directly on the raw WebDriver. As a result, Selenide plugins that customize thePhotographer(e.g. selenide-full-screenshot) are ignored, so screenshots attached to Allure reports don't match the screenshots Selenide itself produces elsewhere in the test suite and are not full page screenshots as users expect.This change replaces the direct WebDriver call with Selenide.screenshot(OutputType.BYTES), which:
Photographer, so plugins likeselenide-full-screenshotapply consistently to Allure attachmentsWebDriverExceptionhandling unchangedNo public API changes, behavior is identical for the default Photographer.
Checklist