Skip to content

Playwright - add java sources to a captured Playwright trace - #1450

Open
antonfilichkin wants to merge 1 commit into
allure-framework:mainfrom
antonfilichkin:feat/playwright-trace-sources-flag
Open

antonfilichkin wants to merge 1 commit into
allure-framework:mainfrom
antonfilichkin:feat/playwright-trace-sources-flag

Conversation

@antonfilichkin

@antonfilichkin antonfilichkin commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Context

Allows attaching java sources to Playwright traces.

Allure only configures Playwright traces to include screenshots and snapshots via

new Tracing.StartOptions()
    .setScreenshots(true)
    .setSnapshots(true)

Playwright allows including java sources by setting PLAYWRIGHT_JAVA_SRC and configuring tracing via

new Tracing.StartOptions()
    .setSources(true)

The problem:

  1. Playwright provides trace as .zip binary
  2. Playwright doesn't have mechanism to suppress synthetic frames from trace, it only handles its own ones. But with Allure enabled - frame 0 is always synthetic AspectJ-weaving glue inserted by AllurePlaywrightAspect, not the real caller - making Trace Viewer's Source tab useless.
  3. Playwright handles trace building on it's binary side

The idea is to add configurable option to allow Allure rewrite sources and remove it's own synthetic frames
Implementation idea:

  • Add allure.playwright.trace.sources (default false) to opt into embedding sources in the trace.
  • Add TraceStackSourceTrimmer, which rewrites the trace.stacks entry in place: it resolves the first file-backed frame in each stack, falling back to stripping the leading run of recognizable AspectJ/Playwright weaving frames when no frame resolves. Fails open on any error, leaving the trace attached unchanged. With some short-circuits to disable zip/json processing - I.e. binary blobs, sources path not set.

Trace examples (both with sources)
Screenshot 2026-09-21 at 12 07 30
npx playwright show-trace trace-after.zip
trace-before.zip
trace-after.zip

Checklist

…spectJ frames from trace stacks

Playwright's Tracing.StartOptions#setSources embeds a stack per action, but
frame 0 is always synthetic AspectJ-weaving glue inserted by
AllurePlaywrightAspect, not the real caller - making Trace Viewer's Source
tab useless without this.

- Add allure.playwright.trace.sources (default false) to opt into embedding
  sources in the trace.
- Add TraceStackSourceTrimmer, which rewrites the trace.stacks entry in
  place: it resolves the first file-backed frame in each stack, falling
  back to stripping the leading run of recognizable AspectJ/Playwright
  weaving frames when no frame resolves. Fails open on any error, leaving
  the trace attached unchanged.
- Declare the module's new compile-time-only dependency on Gson in
  module-info.java.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant