Conversation
Classic builds took the source's latest supported version as AltStore's update candidate without comparing it to the installed version, so a build newer than the source's latest entry was offered that entry as an update: a self-built 2.3.3 was shown the source's 2.2.2 under Updates. Apply the rule marketplace builds already use: only a supported version whose version number is at least the installed one qualifies. Notarized builds keep their existing behaviour of never self-updating.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A Classic build newer than the source's latest AltStore entry lists that older entry under Updates. A
classicbuild is 2.3.3 and the default source lists 2.2.2, so My Apps offers 2.2.2 as an update.StoreApp.setVersionstakes the source's first supported version for AltStore's own entry without comparing it to the installed version. Marketplace builds already compare, but only inside#if MARKETPLACE.Fix
Apply the Marketplace comparison to every non-notarized build and drop the Classic-only fallback. Older or equal entries are no longer offered, newer ones still are. Notarized builds are unchanged.
Testing
On device with a 2.3.3 build and the default source, the "AltStore 2.2.2" row under Updates is gone after sources refresh.