Repository navigation
Fix benchmark regression checks for throughput metrics - #454
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: Fixes #281
Description of changes:
The benchmark
compare --failcommand currently treats an increase in operations per second as a regression and lets a throughput drop pass. Use the report field's direction of improvement when deciding whether the threshold was exceeded. Keep the signed percentage in the report, and preserve the existing comparison for fields without an explicit direction.Added CLI regressions for mean/min/max throughput in both directions, threshold boundaries, and the existing time/file-size behavior. The test subprocess now uses
sys.executableso it runs in the same environment as pytest.Validation: all 79 benchmark CLI/spec tests pass on Python 3.9.25. Six new throughput cases fail against the original comparison logic and pass with the fix.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.