Repository navigation
Fix Ion stream serialization in buffer write benchmarks - #455
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: Related to #325 (Ion buffer-write support).
Description of changes:
Writing an Ion benchmark input containing
1 2with--io-type buffercurrently serializes[1, 2]as a single top-level Ion list. File mode writes the two original values, so the two modes measure different serialization workloads. Even a single top-level list acquires another list wrapper in buffer mode.Pass
sequence_as_stream=Trueto the benchmark wrapper'sdumps, matching its existingdumpimplementation. This preserves empty streams, single values, multiple values, and a top-level list in text and binary output. It does not change the public simpleion default or address the other formats in #325.All 75 benchmark CLI/spec tests pass on Python 3.9. The eight new regression cases fail before the fix and pass afterward; they compare buffer output with file output and repeat the benchmark call to check input reuse. Validation used the pure-Python Ion implementation; the C extension was unavailable locally.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.