Repository navigation
Fix repeated-field multiplicity in struct equivalence - #456
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: Not previously reported.
Description of changes:
ion_equalscurrently considers{field: 1, field: 1, field: 2}equivalent to{field: 1, field: 2, field: 2}. The repeated-field comparison only checks whether each value has any match, allowing the same occurrence to satisfy multiple matches in both directions.Consume each matched occurrence from a temporary list so repeated-field counts matter while field order remains irrelevant. This retains Ion's recursive comparison semantics for unhashable values, NaNs, and signed zero, and does not mutate either input.
Validation: four new regression cases fail before the fix; all seven new cases pass afterward. The Python test suite excluding vector and benchmark tests passes: 21,529 passed, 5 skipped. Vector fixtures and the native C extension were not exercised in this run.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.