Repository navigation
Add regex/exist check to RedfishEndpointPlugin, allow connection manager override - #328
Open
amd-ansonyim wants to merge 4 commits into
Open
amd-ansonyim wants to merge 4 commits into
amd-ansonyim wants to merge 4 commits into
Conversation
…ction override - RedfishEndpointPlugin analyzer: new 'regex' and 'exists' constraint keys - PluginExecutor: plugin config 'connection' key selects a configured connection manager by name (e.g. RedfishSshProxyConnectionManager) instead of CONNECTION_TYPE - Tests for the new constraints, the override, and RedfishEndpointPlugin over the SSH proxy
Redfish plugins (CONNECTION_TYPE = RedfishConnectionManager) now pick their transport from the connection config: - RedfishConnectionManager present: use it (also when both are present) - only RedfishSshProxyConnectionManager present: use the SSH proxy - neither present: skip the plugin with an error The plugin config 'connection' key still forces a specific manager. OOB SSH plugins are unchanged. Adds config/connection-config_redfish_ssh_proxy.example.json and README docs.
…om connection config Redfish plugins choose their connection only from the connection config: - RedfishConnectionManager present (alone or with the proxy): direct Redfish - only RedfishSshProxyConnectionManager present: SSH proxy - neither present: plugin skipped with an error Plugins whose CONNECTION_TYPE is RedfishSshProxyConnectionManager always use the proxy. The plugin config 'connection' key is removed.
The README section documents the connection block inline.
github-actions
Bot
added
the
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
pytest test/unitpytest test/functional(if applicable)pre-commit run --all-filesChecklist