Conversation
Signed-off-by: Jaden Fix <jadenfix20@gmail.com>
Author
|
@andialbrecht, could you approve the pending fork CI and take a look when convenient? This now only fixes the PostgreSQL JSON-path operator |
Signed-off-by: Jaden Fix <jadenfix20@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@?is split into@and a?placeholder, so formattingSELECT data@??withuse_space_around_operators=TrueproducesSELECT data @ ??. Recognize the PostgreSQL JSON-path operator as one token, preserving the following parameter:SELECT data @? ?.Related to the JSON operator documentation linked in #613. This only fixes
@?; it does not resolve that whole issue.?|and?&remain outside this change because they are ambiguous with a?parameter followed by a bitwise operator. Added parsing and formatting regressions plus controls for parameters followed by||,|and&.Validation:
make testpasses on Python 3.10–3.14 (512 passed, 2 expected failures and 1 existing unexpected pass per version); lint, coverage (97%), and package build pass. The full native test matrix also passes on the exact PR commit: Python 3.10–3.14 on Linux and Python 3.11 on macOS and Windows. Confirmed@?tokenization and formatting fail on the base commit and pass with this change, while parameter/operator controls retain their original behavior.pytest)ruff)Required upstream checks still await maintainer approval.
Prepared with OpenAI Codex assistance.