Keep GRANT and REVOKE privilege clauses together when reindenting - #921
Open
adenzhou1350 wants to merge 1 commit into
Open
adenzhou1350 wants to merge 1 commit into
adenzhou1350 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reindent=Truetreats permission names such asSELECTas new statements and REVOKE'sFROMas a query clause:Keep those boundaries together when the statement starts with a DCL keyword. Nested groups still use the existing formatter, and subsequent SELECT statements retain normal indentation. Token classification is unchanged: GRANT/REVOKE remain DCL and SELECT remains DML.
Fixes #409. This is separate from the keyword-classification change discussed in #719.
Validation on native Windows Python 3.14.3:
git diff --checkpass.Tests cover permission lists, REVOKE GRANT OPTION FOR, leading comments, keyword casing, repeat formatting, a following query, and unchanged lexical token types. This is a formatting test, not a live database authorization test.
pytest)ruff)