Group comparisons across intervening comments - #922
Open
adenzhou1350 wants to merge 1 commit into
Open
adenzhou1350 wants to merge 1 commit into
adenzhou1350 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #604.
Comments between a comparison operator and its operand prevented the comparison from being grouped. SELECT columns then became nested identifier lists, causing subsequent columns to drift right even with
strip_comments=True.Skip existing comment tokens while finding comparison operands, but retain them inside the group. Other grouping passes keep their existing behavior. Tests cover block/line comments, hints, nested comparisons, different operand types, statement boundaries, and SELECT indentation.
Validation on Windows / Python 3.14:
git diff --checkpass.AI-assisted implementation, independently reproduced and checked locally. No multi-platform CI or performance claim.