Avoid an extra blank line before aliased subqueries - #923
Open
adenzhou1350 wants to merge 1 commit into
Open
adenzhou1350 wants to merge 1 commit into
adenzhou1350 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #334's spurious blank line.
Query parentheses already insert a leading newline. When an alias wraps one in an
Identifier, the surrounding identifier list inserts another, leaving an empty line before the subquery.Let the query parenthesis own that break. This preserves the existing subquery indentation rather than introducing a new alignment style; ordinary expressions, comma-first layout, wrapping, and blank lines between statements retain their behavior.
Validation on Windows / Python 3.14:
git diff --checkpass.AI-assisted implementation, independently reproduced and checked locally. No other-platform CI or performance claim.