Accept binary file-like SQL streams - #925
Open
adenzhou1350 wants to merge 1 commit into
Open
adenzhou1350 wants to merge 1 commit into
adenzhou1350 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #352.
parsestreamcurrently accepts text streams and rawbytes, but rejects binary file-like objects such asBytesIOandGzipFilebefore reaching its existing byte-decoding logic. AcceptIOBasestreams and update the public annotation/docstring; keep decoding, statement grouping, error propagation and stream ownership unchanged.Tests cover plain/gzip streams with UTF-8 and explicit Latin-1, default UTF-8 decoding, text streams, invalid encodings and unsupported input objects. Six regression cases fail on unchanged master; all eight pass with this change.
Local validation on Windows / CPython 3.14.3:
python -B -m ruff check sqlparse/andgit diff --check: pass.This does not add incremental/chunked input processing: streams are still read by the existing lexer path. Linux and maintainer CI have not been run locally.