fix: recognize alternative F-Droid installers - #56
Merged
Merged
Conversation
andre487
enabled auto-merge (squash)
October 3, 2026 14:46
andre487
disabled auto-merge
October 3, 2026 14:47
andre487
enabled auto-merge (squash)
October 3, 2026 14:48
APK artifacts
Built from commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative F-Droid clients were treated as GitHub installers because automatic source selection recognized only the official package names. Detect installers that handle fdroidrepo/fdroidrepos repository links, restricting the query to the actual installer package so unrelated installed clients cannot change the result. Preserve official/privileged installer support and explicit user choices; unknown installers or failed capability lookup require a choice.
Open the F-Droid package web link without forcing the official client, allowing compatible clients or a browser to handle it. F-Droid mode continues to query its API and delegate installation. Update EN/RU behaviour and release-check documentation.
Validation:
bundle exec fastlane android android_checkspassed locally: 177 JVM tests, lint, debug and verified unsigned release builds. New Robolectric tests cover SDK 26 and 35, both schemes, unrelated clients, unknown installers and manual override. The UI test checks the unrestricted package link and absence of APK downloading. No physical-device or real-client installation was performed.Addresses: https://gitlab.com/fdroid/fdroiddata/-/merge_requests/47508#note_3949232164