Repository navigation
Conversation
The microbenchmark module only sets minSdk, so the test APK is built with targetSdkVersion 21. On devices whose minimum supported target SDK is higher (28 on a Galaxy S24+ running Android 17) every benchmark fails with 'ERRORS (not suppressed): ACTIVITY-MISSING'. Set testOptions.targetSdk to the module's compileSdk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
microbenchmarkmodule only setsminSdk, so its test APK is built withtargetSdkVersion21.On a Galaxy S24+ running Android 17 (where
ro.build.version.min_supported_target_sdkis 28) the benchmarks fail with:The device also shows a warning that the app was built for an older version of Android.
This PR sets
testOptions.targetSdkto the module'scompileSdk(35).With that change the benchmarks start and finish on the same device.
Tested with
AutoBoxingBenchmark, together with #373 (maindoes not compile without it).