Repository navigation
refactor(@angular/build): flatten builderName in cache directory path - #34327
Merged
alan-agius4 merged 1 commit intoOct 13, 2026
Merged
Conversation
alan-agius4
force-pushed
the
fix/normalize-cache-builder-name
branch
from
October 13, 2026 13:32
b421640 to
d2b4662
Compare
alan-agius4
added
action: review
alan-agius4
force-pushed
the
fix/normalize-cache-builder-name
branch
from
October 13, 2026 13:33
d2b4662 to
c3a8150
Compare
alan-agius4
changed the title
clydin
approved these changes
Oct 13, 2026
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the cache path normalization logic to remove '@' characters and replace both ':' and '/' characters with '-' in the builder name. The corresponding unit tests have been updated to reflect this change. There are no review comments, and I have no feedback to provide.
alan-agius4
added
action: merge
Strip '@' and replace '/' in addition to ':' when normalizing builderName in normalizeCacheOptions so scoped builder names produce a single flat cache directory instead of nested subdirectories.
alan-agius4
force-pushed
the
fix/normalize-cache-builder-name
branch
from
October 13, 2026 13:34
c3a8150 to
d345e32
Compare
Collaborator
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strip
@and replace/in addition to:when normalizingbuilderNameinnormalizeCacheOptionsso scoped builder names (such as@angular/build:unit-test) produce a single flat cache directory (angular-build-unit-test) instead of nested subdirectories.