Repository navigation
refactor(@angular/build): collect and log build errors in library builder - #34328
Merged
Merged
Conversation
alan-agius4
added
the
target: minor
…lder Instead of throwing errors inside `buildAction` and `compileLibrary` during progress spinner execution, collect formatted diagnostic errors, warnings, and informational logs into `BuildActionResult` and log them via `context.logger` after `withProgress` completes, matching the behavior of the `application` builder.
alan-agius4
force-pushed
the
fix/library-error-logging
branch
from
October 13, 2026 14:55
2973f1f to
c22b3bf
Compare
alan-agius4
added
the
action: review
alan-agius4
marked this pull request as ready for review
October 13, 2026 16:05
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the library builder pipeline to aggregate and log build diagnostics (errors, warnings, and informational logs) as structured results (BuildActionResult) rather than throwing exceptions immediately. Key changes include updating buildAction, compileLibrary, and dependency verification to return diagnostic messages, introducing helper functions like logMessages and collectEntryPointsToBundle, and updating corresponding unit tests to assert on the logged output. I have no feedback to provide as there are no review comments.
clydin
approved these changes
Oct 13, 2026
alan-agius4
added
action: merge
Collaborator
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of throwing errors inside
buildActionandcompileLibraryduring progress spinner execution, collect formatted diagnostic errors, warnings, and informational logs intoBuildActionResultand log them viacontext.loggerafterwithProgresscompletes, matching the behavior of theapplicationbuilder.