Repository navigation
refactor(@angular/build): export NormalizedAssetsPattern and avoid mutating input patterns - #34354
Merged
alan-agius4 merged 1 commit intoOct 15, 2026
Conversation
alan-agius4
added
target: minor
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors asset pattern normalization by introducing a dedicated NormalizedAssetsPattern interface, simplifying the directory check logic, and cleaning up imports and JSDoc comments. It also streamlines tslib dependency resolution in library package manifests and adds tests for asset ignoring. Feedback highlights that the simplified statSync call with throwIfNoEntry: false could still throw on non-ENOENT errors (like permission issues), and recommends wrapping it in a try-catch block to ensure robustness.
alan-agius4
force-pushed
the
refactor-normalize-asset-patterns
branch
from
October 15, 2026 10:56
384feda to
792654f
Compare
…tating input patterns
Export the `NormalizedAssetsPattern` interface from `normalize-asset-patterns.ts`, avoid mutating input `AssetPatternClass` objects in place, and simplify directory detection using `statSync(..., { throwIfNoEntry: false })`.
Also import `normalizeAssetPatterns` directly in `library/options.ts` and add test coverage for asset `ignore` patterns.
alan-agius4
force-pushed
the
refactor-normalize-asset-patterns
branch
from
October 15, 2026 13:27
c4616df to
2809844
Compare
clydin
approved these changes
Oct 15, 2026
alan-agius4
added
action: merge
Collaborator
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Export the
NormalizedAssetsPatterninterface fromnormalize-asset-patterns.ts, avoid mutating inputAssetPatternClassobjects in place, and simplify directory detection usingstatSync(..., { throwIfNoEntry: false }).Also import
normalizeAssetPatternsdirectly inlibrary/options.tsand add test coverage for assetignorepatterns.