Repository navigation
Conversation
…ve to the workspace root The Vite-based dev server read `sslKey` and `sslCert` relative to the current working directory, so serving failed with `ENOENT` when `ng serve` ran from a subdirectory of the workspace and the paths in `angular.json` were relative. Resolve both paths against the workspace root, as the webpack dev server already does. The new dev-server `ssl` spec covers relative paths. It fails with `ENOENT` without this change.
alan-agius4
requested changes
Oct 19, 2026
Collaborator
There was a problem hiding this comment.
This should be done in https://github.com/angular/angular-cli/blob/main/packages/angular/build/src/builders/dev-server/options.ts
Similar to
and
alan-agius4
added
action: cleanup
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Vite dev-server configuration to resolve the sslCert and sslKey paths relative to the workspace root. Additionally, a new test suite has been added to verify this behavior. There are no review comments, and I have no feedback to provide.
… relative to the workspace root
alan-agius4
reviewed
Oct 19, 2026
… relative to the workspace root
MeAkib
force-pushed
the
fix/dev-server-ssl-paths
branch
from
October 19, 2026 09:37
0ae6773 to
08e9727
Compare
alan-agius4
approved these changes
Oct 19, 2026
alan-agius4
added
action: merge
clydin
requested changes
Oct 19, 2026
clydin
left a comment
clydin
left a comment
Member
There was a problem hiding this comment.
This breaks legitimate use cases such as:
ng serve --ssl --ssl-key "$HOME/.certs/key.pem" --ssl-cert "$HOME/.certs/cert.pem"
… relative to the workspace root
alan-agius4
added
the
action: review
thekhegay
reviewed
Oct 20, 2026
…sslCert` relative to the workspace root Previously, the esbuild-based dev-server passed relative `sslKey` and `sslCert` paths to Vite as is, so they were read relative to the current directory and `ng serve` failed with ENOENT when run outside the workspace root. The paths are now resolved against the workspace root, matching `@angular/build`.
thekhegay
approved these changes
Oct 22, 2026
thekhegay
left a comment
thekhegay
left a comment
Contributor
There was a problem hiding this comment.
lgtm, build-angular dev-server now resolves sslKey/sslCert from workspace root same as @angular/build, and new spec covers that path
clydin
approved these changes
Oct 22, 2026
clydin
removed
the
action: review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Vite-based dev server read
sslKeyandsslCertrelative to the current working directory, so serving failed withENOENTwhenng serveran from a subdirectory of the workspace and the paths inangular.jsonwere relative. Resolve both paths against the workspace root, as the webpack dev server already does.