Skip to content

Address zizmor checks#3700

Merged
jhuleatt merged 3 commits into
angular:mainfrom
jhuleatt:zizmor
Jul 7, 2026
Merged

Address zizmor checks#3700
jhuleatt merged 3 commits into
angular:mainfrom
jhuleatt:zizmor

Conversation

@jhuleatt

@jhuleatt jhuleatt commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Checklist

  • Issue number for this PR: #nnn (required)
  • Docs included?: (yes/no; required for all API/functional changes)
  • Test units included?: (yes/no; required)
  • In a clean directory, yarn install, yarn test run successfully? (yes/no; required)

Description

https://docs.zizmor.sh/

Code sample

jhuleatt added 2 commits July 7, 2026 14:18
TAG=agy
CONV=fb008099-c1ce-4ef0-a723-561dde93aeff
@jhuleatt jhuleatt requested a review from armando-navarro July 7, 2026 14:51
@jhuleatt jhuleatt enabled auto-merge (squash) July 7, 2026 14:58

@armando-navarro armando-navarro left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct me if I'm wrong, but I believe some version comments are mismatched to their SHAs. I believe Dependabot uses the comment as the version baseline, so these mismatches would mislead it.

Comment thread .github/workflows/codeql-analysis.yml Outdated
Comment thread .github/workflows/codeql-analysis.yml Outdated
Comment thread .github/workflows/codeql-analysis.yml Outdated
Comment thread .github/workflows/test.yml Outdated
Comment thread .github/workflows/test.yml Outdated
Comment thread .github/workflows/test.yml Outdated
@jhuleatt jhuleatt requested a review from armando-navarro July 7, 2026 19:08
@jhuleatt

jhuleatt commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator Author

Sorry about the bad versions the first time around @armando-navarro. I've updated them and double-checked.

@armando-navarro armando-navarro left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you.

@jhuleatt jhuleatt merged commit a812d22 into angular:main Jul 7, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants