refactor(schematics): derive the firebase-tools version message from a shared constant#3704
Merged
armando-navarro merged 2 commits intoJul 9, 2026
Conversation
…a shared constant The minimum-version check and its error message were separate string literals. They drifted once before (the message read "13.0.0+" while the check required 14.0.0). A single minFirebaseToolsVersion constant, with the message built from it, keeps the two in sync.
tyler-reitz
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3662. The firebase-tools minimum-version check and its error message were separate string literals that drifted once (the message read "13.0.0+" after the check was raised to 14). This derives the message from a single
minFirebaseToolsVersionconstant so the two stay in sync. No behavior change.Fixes #3703