Repository navigation
docs: note the removed @angular/platform-server peer in the v21 upgrade guide - #3795
armando-navarro wants to merge 1 commit into
Conversation
…de guide The upgrade guide's "Other notes" already lists the removed @angular/platform-browser-dynamic peer. The optional @angular/platform-server peer is gone too, and apps need no change.
armando-navarro
added
bump: patch
tyler-reitz
left a comment
tyler-reitz
left a comment
There was a problem hiding this comment.
Content looks right, so I am holding the approval rather than giving it, since approval is the only gate here and it would make this mergeable ahead of rc.2. Ping me when rc.2 is ready and I will approve it then.
Two small things while it waits.
The sentence says "peer dependency" twice. Reads better collapsed:
The obsolete
@angular/platform-browser-dynamicand the unused optional@angular/platform-serverpeer dependencies were removed. No action is needed.
And @angular/platform-browser-dynamic is already gone from published 20.1.0, so for anyone upgrading from latest that half of the bullet describes something their current version already did. Worth either saying which removal landed when, or leaving it, since "No action is needed" covers both either way. Your call, it is the sentence this PR happens to touch rather than anything it introduces.
2 participants
Caution
Do not merge until AngularFire 21.0.0-rc.2 is ready to release
The guide's commands install
21.0.0-rc.1, which still declares this peer. Merge this together with the 21.0.0-rc.2 release.Refs #3667
Adds the removal of the optional
@angular/platform-serverpeer (#3792) to the "Other notes" list indocs/version-21-upgrade.md, next to the existing note about@angular/platform-browser-dynamic.