Skip to content

docs: add ChangeDetectionStrategy.Eager to Autocomplete examples#33450

Closed
msmallest wants to merge 1 commit into
angular:mainfrom
msmallest:docs-autocomplete-eager
Closed

docs: add ChangeDetectionStrategy.Eager to Autocomplete examples#33450
msmallest wants to merge 1 commit into
angular:mainfrom
msmallest:docs-autocomplete-eager

Conversation

@msmallest

@msmallest msmallest commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

The documentation examples were made when Zone.js and Eager change detection were default. This has caused issues, see issue: #33443.

Explicitly adding changeDetection: ChangeDetectionStrategy.Eager to StackBlitz examples is one key piece needed in the current times. Until a sweep through all the examples makes them compatible with both new change detection defaults.

On the scale of: PR to make everything zoneless + OnPush default compatible > PR to make all examples have zone + Eager for now> make one PR to provide zone and separate PR for various component examples for now, I assume the last one like this PR is the most realistic.

This is the first of my proposed "separate PR for various component examples for now" plan. Provided there are no objections, I am just going to go down the line alphabetically in individual PRs.

edit: the zone provider PR: #33449

edit: I will not open more PRs unless I get maintainer approval

@msmallest msmallest force-pushed the docs-autocomplete-eager branch from 1b86dd2 to 67c054f Compare June 26, 2026 03:43
@msmallest

Copy link
Copy Markdown
Contributor Author

As per some updates in the respective issue, I was too harsh on the overall state of the compatibility. Sorry.. There is still plenty to be updated, but not as many as I thought. I thought it was better for a bandaid fix first rather than propose a huge chunk of changes with more comprehensive scope, but I think there is a limited enough slice of them that they can be fixed outright in a PR or a few split up ones.

Additionally, autocomplete was already in a solid state where only one example needs a change: https://gist.github.com/michael-small/3b04460a8e9bcb114cf0aeb05f447b91. I picked autocomplete as the first alphabetical, but it does not need as many changes as other ones.

@msmallest msmallest closed this Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: docs Related to the documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant