Repository navigation
build: guard branch-manager against forks and harden checkout - #34006
Merged
crisbeto merged 1 commit intoOct 23, 2026
Merged
Conversation
Restores if: github.event.repository.fork == false in .github/workflows/assistant-to-the-branch-manager.yml and adds persist-credentials: false to actions/checkout in .github/workflows/google-internal-tests.yml.
angular-robot
Bot
added
the
area: build & ci
josephperrott
added
action: merge
crisbeto
approved these changes
Oct 23, 2026
Member
|
@josephperrott looks like this doesn't merge cleanly everywhere. |
josephperrott
added
target: minor
Member
Author
|
@crisbeto Updated to only target main, will create the patch only change shortly. |
josephperrott
added
target: minor
Member
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change restores
if: github.event.repository.fork == falseon.github/workflows/assistant-to-the-branch-manager.ymlper GHSSpull_request_targetpolicy remediation (b/577107676).Because 100% of pull requests in
angular/componentsoriginate from forks (only_allow_releasable_branches: true) andbranch-managerrequirescontext.eventName === 'pull_request_target'along withsecrets.ANGULAR_ROBOT_PRIVATE_KEYto set mergeability commit status, the previoushead.repo.fork == falsecheck caused all fork PR runs to be skipped. Restoring the base repository fork check ensures branch-manager triggers as intended on upstream PRs while preventing runs on external forks.Additionally,
persist-credentials: falseis added toactions/checkoutin.github/workflows/google-internal-tests.ymlfor defense-in-depth.