Skip to content

build: update jasmine dependencies to v7 - #3922

Open
angular-robot wants to merge 1 commit into
angular:mainfrom
angular-robot:ng-renovate/major-jasmine-dependencies
Open

build: update jasmine dependencies to v7#3922
angular-robot wants to merge 1 commit into
angular:mainfrom
angular-robot:ng-renovate/major-jasmine-dependencies

Conversation

@angular-robot

@angular-robot angular-robot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
jasmine (source) 6.3.07.0.0 age adoption passing confidence
jasmine (source) ^6.0.0^7.0.0 age adoption passing confidence
jasmine-core (source) 6.3.07.0.2 age adoption passing confidence

  • If you want to rebase/retry this PR, check this box

Release Notes

jasmine/jasmine-npm (jasmine)

v7.0.0

Compare Source

Please see the release notes.

jasmine/jasmine (jasmine-core)

v7.0.2

Compare Source

v7.0.1

Compare Source

Please see the release notes.

v7.0.0

Compare Source

Please see the release notes.

@angular-robot angular-robot added action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: automation This PR is targeted to only merge into the branch defined in Github [bot use only] labels Aug 17, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades jasmine and jasmine-core to version 7 across several package files and updates the lockfiles accordingly. A review comment points out that @types/jasmine should also be updated to version 7 to prevent potential TypeScript compilation errors due to major version mismatches.

"@types/node": "24.13.3",
"chromedriver": "^151.0.0",
"jasmine-core": "6.3.0",
"jasmine-core": "7.0.1",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The major version of jasmine-core is updated to 7.0.1, but @types/jasmine remains at ~6.0.0 (line 28). This major version mismatch can lead to TypeScript compilation errors or missing type definitions for Jasmine v7 features. Update @types/jasmine to ~7.0.0 to match the new major version of Jasmine.

@angular-robot
angular-robot force-pushed the ng-renovate/major-jasmine-dependencies branch 2 times, most recently from 3306a02 to 890eb36 Compare August 20, 2026 13:06
See associated pull request for more information.
@angular-robot
angular-robot force-pushed the ng-renovate/major-jasmine-dependencies branch from 890eb36 to 4690f63 Compare August 21, 2026 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: automation This PR is targeted to only merge into the branch defined in Github [bot use only]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant