fix(ci): check PR body for linked issue on non-default branches - #43964
Open
major wants to merge 1 commit into
Open
fix(ci): check PR body for linked issue on non-default branches#43964major wants to merge 1 commit into
major wants to merge 1 commit into
Conversation
- fall back to parsing PR description for issue references in pr-standards - prevent false-positive needs:issue labels on PRs targeting v2 Signed-off-by: Major Hayden <major@mhtx.net>
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Potential Duplicate Found:
This appears to be a previous attempt to fix the same problem. You should check whether PR #38408 was closed/merged and why a new PR is needed, or if this is a duplicate that should be closed in favor of the existing PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #43963
Type of change
What does this PR do?
The
check-standardsjob in.github/workflows/pr-standards.ymlpreviously checked for linked issues exclusively via GraphQLpullRequest.closingIssuesReferences.totalCount.Because GitHub only recognizes closing keywords on PRs targeting the repository's default branch (
dev), PRs targetingv2always return0and trigger false-positiveneeds:issuewarnings.This PR adds a fallback that inspects the PR description for closing keywords (such as
Closes #<number>orFixes #<number>).This matches the parsing logic in
check-complianceand allows PRs targetingv2and other non-default branches to pass validation.How did you verify your code works?
check-compliancechecks inpr-standards.yml.Screenshots / recordings
N/A (CI workflow fix)
Checklist