Repository navigation
fix(app): make the subagent bar say what it is and drop dead controls - #57922
Open
kitlangton wants to merge 2 commits into
Open
kitlangton wants to merge 2 commits into
kitlangton wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Looks good. I put the Child Session story through Playwright on the base and on this branch, with screenshots of each below. The bar is now one line naming the subagent, its task (the child session's title, which the subagent tool sets to the task description), the run state with elapsed time, and the way back. No model is shown. The updated subagent-bar.spec.ts passes, and the packages/app type check passes.
Public API is unchanged: this is a web app UI change only, with two new English strings.
No concerns.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Viewing a subagent session showed a two-row bar: a faint "Running · 24m 35s" line, then the agent, provider/model and variant laid out like the composer's pickers, which can't be changed in a child session. Nothing said it was a subagent or what it was doing.
The bar is now one 44px line on the composer's 16px inset:
Changes stay inside
subagent-bar.tsx, one new prop fromregion.tsx, two English strings, the Child Session story (now arg-driven: status, title, permission dock) and the existing component test.Proof (before above, after below; fictional titles)
Running, light/dark, done, failed, interrupted:

Permission dock above, RTL, narrow (420px window), long title with tooltip:

Checks
bun run --cwd packages/app typecheckbun run lint:changed origin/beta: 0 problemscomponent-tests/subagent-bar.spec.tspasses (updated: the bar names the subagent and its task, shows no model, and no composer renders)