Skip to content

fix(app): make the subagent bar say what it is and drop dead controls - #57922

Open
kitlangton wants to merge 2 commits into
betafrom
subagent-bar
Open

kitlangton wants to merge 2 commits into
betafrom
subagent-bar

Conversation

@kitlangton

Copy link
Copy Markdown
Contributor

Summary

Viewing a subagent session showed a two-row bar: a faint "Running · 24m 35s" line, then the agent, provider/model and variant laid out like the composer's pickers, which can't be changed in a child session. Nothing said it was a subagent or what it was doing.

The bar is now one 44px line on the composer's 16px inset:

  • Who and what: "General subagent" followed by the subagent's task (its session title), truncating with a tooltip that shows the full task and the model.
  • State: a spinner or Done/Failed/Interrupted glyph, the word, and the elapsed or final time. A status change fades in; a finished run opens at rest. Below 24rem the word hides and the glyph and time stay.
  • Way back: "Main session" with its Esc hint, unchanged.
  • The read-only model and variant chips are gone from the bar; the model is in the tooltip.

Changes stay inside subagent-bar.tsx, one new prop from region.tsx, two English strings, the Child Session story (now arg-driven: status, title, permission dock) and the existing component test.

Proof (before above, after below; fictional titles)

Running, light/dark, done, failed, interrupted:
states

Permission dock above, RTL, narrow (420px window), long title with tooltip:
more

Checks

  • bun run --cwd packages/app typecheck
  • bun run lint:changed origin/beta: 0 problems
  • component-tests/subagent-bar.spec.ts passes (updated: the bar names the subagent and its task, shows no model, and no composer renders)

@opencode-agent opencode-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I put the Child Session story through Playwright on the base and on this branch, with screenshots of each below. The bar is now one line naming the subagent, its task (the child session's title, which the subagent tool sets to the task description), the run state with elapsed time, and the way back. No model is shown. The updated subagent-bar.spec.ts passes, and the packages/app type check passes.

Public API is unchanged: this is a web app UI change only, with two new English strings.

No concerns.

Before

After

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant