Repository navigation
fix(app): open the command palette from anywhere - #57933
Merged
Merged
Conversation
kitlangton
force-pushed
the
palette-everywhere
branch
from
October 21, 2026 22:03
a38b9ac to
3ee1089
Compare
Contributor
There was a problem hiding this comment.
I recommend merging this. I ran e2e/regression/command-palette.spec.ts on both branches. The new Settings test fails on the base, where ⌘K does nothing on Settings, and passes with this change. Both branches fail the same 3 other tests in that spec, so those failures are not caused by this change. tsc -b and the command unit tests pass.
The registry keeps the newest registration per key, so the shell's palette has the lowest priority: routes that register their own still take over, and the shell's is used again when they unmount.
Public API: unchanged. Only internal registration keys in packages/app changed.
No blocking concerns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
⌘K did nothing on the Settings page.
Cause: the shortcut only works when some route has registered a
command.palettecommand. Home, sessions and the new session screen each register their own, but the Settings route registered none, so the shortcut found nothing to run there.Fix: the shell now registers the Home palette (commands, sessions, settings) as a fallback that every route gets. Every palette registration now shares the
palettekey, so the newest surface wins: sessions and new session keep their file palette, and Home's sessions view keeps its focused-server palette. Home's start page now uses the shell's copy instead of its own duplicate.Surfaces checked:
documentin the capture phase, before the terminal sees the key.browser-pane-restore.spec.ts.Test:
e2e/regression/command-palette.spec.tsgains "opens from the Settings page and finds another setting". It opens Settings with ⌘, , presses ⌘K, searches "theme", and checks that Settings moves to Appearance with the Theme row in view.