Repository navigation
fix(app): forward ⌘L from a focused browser page to the address field - #57965
Merged
Merged
Conversation
kitlangton
force-pushed
the
side-panel-cmd-l
branch
from
October 21, 2026 23:44
6be6840 to
d5a637f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
⌘L (Ctrl+L on Windows and Linux) now focuses and selects the side panel browser's address field while keyboard focus is in the page. Before, pressing it there did nothing.
How
The page now hands ⌘L to the pane the same way it already hands over ⌘T and ⌘W.
pageShortcutclaims it, main forwards it to the window, and the pane dispatches it inside#browser-panel. There, the existing scopedbrowser.addresscommand answers it. So ⌘L takes the same route in the page as on the pane's own surface.The dedicated
addresspane event that used to carry ⌘L from the page is removed (chromium.ts, pane.ts, ipc.ts, connection.ts, model.ts, panel.tsx). That leaves one route for every forwarded chord.Unchanged
Tests
keys.test.ts: ⌘L and Ctrl+L are forwarded, including on Dvorak (L on the physical P key).browser-pane-restore.spec.ts: new story. ⌘L is pressed in the page, then on the pane's surface, and must select the whole URL each time. Pressed in the main column, it must leave the address alone.Known limit
Like ⌘T and ⌘W, the page only forwards the default chord. If the address command is rebound, the page still claims ⌘L, but nothing answers it.