Repository navigation
fix(app): restore beta typecheck in activity chip fixture - #57969
Closed
kitlangton wants to merge 1 commit into
Closed
kitlangton wants to merge 1 commit into
kitlangton wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
This looks good. On the base, typecheck in packages/app fails with TS2307 on @opencode/ui/context/marked; with this change it passes. No other code still references MarkedProvider, so removing the wrapper leaves nothing dangling.
The public API is unchanged: the change only touches a dev fixture.
No concerns.
This was referenced Oct 22, 2026
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
typecheckis red on beta:activity-chips.fixture.tsx(added in #57893) imports@opencode/ui/context/marked, which #57937 removed.What Changes
Drop the unused
MarkedProviderwrapper and import from the fixture, plus blank-line spacing the lint rule requires now that the file is touched.Verification
bun typecheckinpackages/apppasses;lint:changedclean. Mechanical, no proof.