Skip to content

fix(app): restore beta typecheck in activity chip fixture - #57969

Closed
kitlangton wants to merge 1 commit into
betafrom
fix-chip-typecheck
Closed

kitlangton wants to merge 1 commit into
betafrom
fix-chip-typecheck

Conversation

@kitlangton

Copy link
Copy Markdown
Contributor

Why

typecheck is red on beta: activity-chips.fixture.tsx (added in #57893) imports @opencode/ui/context/marked, which #57937 removed.

What Changes

Drop the unused MarkedProvider wrapper and import from the fixture, plus blank-line spacing the lint rule requires now that the file is touched.

Verification

bun typecheck in packages/app passes; lint:changed clean. Mechanical, no proof.

@opencode-agent opencode-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. On the base, typecheck in packages/app fails with TS2307 on @opencode/ui/context/marked; with this change it passes. No other code still references MarkedProvider, so removing the wrapper leaves nothing dangling.

The public API is unchanged: the change only touches a dev fixture.

No concerns.

@kitlangton

Copy link
Copy Markdown
Contributor Author

Superseded by #57908, which landed the same activity-chips fixture fix on beta (423b01e).

@kitlangton kitlangton closed this Oct 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant