Close JSONL responses when decoding or reading fails - #1929
Open
betacatsling wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batch-result JSONL decoders leave the HTTP response open when parsing or reading fails. Add
finallycleanup to both decoder variants so those exceptions release the response, as SSE streams already do.The regressions exercise
messages.batches.results()through an in-memory HTTP transport, cover invalid JSON, read failures and successful exhaustion, and check that the underlying stream closes exactly once. On the unchanged base: 4 failed, 2 passed. With the fix: decoder and SSE tests 35 passed, with no live API calls. Ruff and changed-file Pyright checks passed. Mypy reports the same 67 pre-existing diagnostics in three unchanged dependency modules on the base and patched versions.The newline parsing itself is unchanged; #1778 addresses a separate CRLF boundary issue in this decoder.
AI assistance was used for implementation and local verification.
Fixes #1928.