fix: explain oversized system prompts#1097
Open
w3lld1 wants to merge 1 commit into
Open
Conversation
tapheret2
reviewed
Jul 10, 2026
tapheret2
left a comment
There was a problem hiding this comment.
Review notes on “fix: explain oversized system prompts”
Touched files (3): src/claude_agent_sdk/_internal/transport/subprocess_cli.py, src/claude_agent_sdk/types.py, tests/test_transport.py
Diff size (approx): +75 / -1
Observations
- Nice that tests/fixtures are included with the change — that helps a lot for review confidence.
Questions / nits
- Does this need a changelog / release note entry for the target version?
- Any user-facing behavior change that should be called out in the PR body?
Thanks @w3lld1 for the contribution — left this as an independent review pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
system_promptvalues before Linux rejects the CLI subprocess with a rawArgument list too longerrorsystem_prompt={"type": "file", ...}workaround in the SDK errorClaudeAgentOptionsFixes #1096
Test plan
uv run --extra dev ruff format src/claude_agent_sdk/_internal/transport/subprocess_cli.py src/claude_agent_sdk/types.py tests/test_transport.pyuv run --extra dev ruff check src/claude_agent_sdk/_internal/transport/subprocess_cli.py src/claude_agent_sdk/types.py tests/test_transport.pyuv run --extra dev mypy src/claude_agent_sdk/_internal/transport/subprocess_cli.py src/claude_agent_sdk/types.pyuv run --extra dev pytest tests/test_transport.py -q