Conversation
| retry.logCompletion(log, "Modifying properties for table " + tableName); | ||
| return props; | ||
| } catch (ConcurrentModificationException cme) { | ||
| } catch (ConcurrentModificationException | TableNotFoundException cme) { |
There was a problem hiding this comment.
This catch block triggers a retry, but that doesn't make sense for the case where the table doesn't exist. It only makes sense for concurrent modifications.
There was a problem hiding this comment.
I added this catch because of the call to tryToModifyProperties above, in that method I had to to add the TableNotFoundException as the method was throwing TableNotFoundException wrapped in AccumuloException. So now I think this method has to accommodate for that
| @@ -1039,13 +1036,14 @@ public void setProperty(final String tableName, final String property, final Str | |||
| setPropertyNoChecks(tableName, property, value); | |||
| checkLocalityGroups(tableName, property); | |||
| } catch (TableNotFoundException | IllegalArgumentException e) { | |||
| throw new AccumuloException(e); | |||
| throw new TableNotFoundException((ThriftTableOperationException) e); | |||
There was a problem hiding this comment.
Build is failing on line 1039 with impossible cast from TableNotFoundException to ThriftTableOperationException. Strangely, I get an error when I try to just throw new TableNotFoundException(e) saying its expecting the Thrift exception, but when it is a Thrift exception, the impossible cast error occurs
|
Everything working locally, Kicked off IT build to see if anything breaks |
This branch has not been deployed
2 participants
Remove wrapping TableNotFoundException in AccumuloException in a few
TableOperations.javamethods. This way the methods can throw TableNotFoundException directly.closes #5602