Skip unnecessary sleep when verifying MAC tservers are up - #6573
Merged
Merged
Conversation
Amemeda
approved these changes
Oct 1, 2026
Amemeda
approved these changes
Oct 1, 2026
dlmarion
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looking for places that have the potential to speed up a lot of tests. Found this 500ms sleep that was happening even if the condition we were looking for was met. So even when all expected tservers were present, the sleep still happens. This PR skips that unnecessary sleep saving about 0.5 seconds per MAC start.
When merging into main,
verifyUpwas rewritten there but the same issue exists. I'll fix it in the merge commit.