Stricter configuration validation - #6577
Open
ArbaazKhan1 wants to merge 1 commit into
Open
ArbaazKhan1 wants to merge 1 commit into
ArbaazKhan1 wants to merge 1 commit into
Conversation
Contributor
Author
|
I know PR #6487 is also working on updating Properties. It looks like the work done there v here is mostly orthogonal, but depending on which get merged in first there will likely be some merge conflict, since they both touch the same block in Property.java. Worth double-checking once #6487 settles: if it ends up marking a property "required" just because its default value is null, that would wrongly flag every prefix property as required too, since both PREFIX and CLOSED_PREFIX types always have a null default by convention. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes issue #6216
CLOSED_PREFIXto represent non-extensible namespace prefixesPropertyType.PREFIXremains open for user-extensible properties (e.g. table.custom, table.iterator ...)tserver,manager,gc,monitor,rpc,sserver,compactor,compaction-coordinator, andinstancetoCLOSED_PREFIXConfigCheckUtil,AccumuloConfiguration,ConfigurationImpl,ConfigurationDocGen, andSystemPropUtilto handle CLOSED_PREFIX whereverPropertyType.PREFIXwas previously checkedDefaultConfigurationstatic initializer to excludeCLOSED_PREFIXproperties, which also have null default values